Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: removes e2e tests in favor of the sdk-tests suite #155

Merged
merged 2 commits into from
Jan 2, 2025
Merged

test: removes e2e tests in favor of the sdk-tests suite #155

merged 2 commits into from
Jan 2, 2025

Conversation

ctran88
Copy link
Contributor

@ctran88 ctran88 commented Dec 20, 2024 •
edited
Loading

BEGIN_COMMIT_OVERRIDE
feat!: return void instead of boolean for Passage.user.delete
END_COMMIT_OVERRIDE

What's New?

Screenshots (if appropriate):

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have manually tested my code thoroughly
  • I have added/updated inline documentation for public facing interfaces if relevant
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing integration and unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional context

@ctran88 ctran88 marked this pull request as ready for review December 20, 2024 23:05
@ctran88 ctran88 requested a review from a team December 20, 2024 23:05
@ctran88 ctran88 force-pushed the PSG-5524-update-arg-and-filenames branch from 736b3c8 to 0cd1a00 Compare December 23, 2024 22:41
@ctran88 ctran88 marked this pull request as draft December 23, 2024 22:50
@ctran88 ctran88 force-pushed the PSG-5524-update-arg-and-filenames branch from 8050f95 to 86fc0b2 Compare January 2, 2025 20:27
@ctran88 ctran88 force-pushed the PSG-4994-remove-e2e-tests branch from 182d15f to ab67390 Compare January 2, 2025 20:38
@ctran88 ctran88 marked this pull request as ready for review January 2, 2025 20:39
Base automatically changed from PSG-5524-update-arg-and-filenames to refactor-user-class January 2, 2025 20:53
@vanessa-passage
Copy link
Contributor

Will we no longer run these tests on the PR? I know they are now in the test suite, when does the test suite run? Do we plan to have anything in place to prevent merging PRs that are breaking the tests in the test suite?

@ctran88
Copy link
Contributor Author

ctran88 commented Jan 2, 2025

Will we no longer run these tests on the PR? I know they are now in the test suite, when does the test suite run? Do we plan to have anything in place to prevent merging PRs that are breaking the tests in the test suite?

currently that test suite is run manually, but we are working on getting it in CI so eventually they should run on SDK PRs

@ctran88 ctran88 force-pushed the PSG-4994-remove-e2e-tests branch from e2cdc67 to e3fd888 Compare January 2, 2025 21:00
@vanessa-passage
Copy link
Contributor

currently that test suite is run manually, but we are working on getting it in CI so eventually they should run on SDK PRs

Got it, how do you feel about waiting to merge this PR until the CI is updated? I fear removing these could slow development and make it harder to test.

@ctran88 ctran88 force-pushed the refactor-user-class branch from 720ac40 to 7988bec Compare January 2, 2025 21:19
@ctran88
Copy link
Contributor Author

ctran88 commented Jan 2, 2025

Got it, how do you feel about waiting to merge this PR until the CI is updated? I fear removing these could slow development and make it harder to test.

none of the sdks will get published until they pass the sdk tests anyways, so these tests don't have too much bearing on the release readiness. but it doesn't hurt to keep them in either so not opposed to keeping them until the CI is hooked up.

Base automatically changed from refactor-user-class to main January 2, 2025 21:35
vanessa-passage
vanessa-passage approved these changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@vanessa-passage vanessa-passage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. My reason to suggest the waiting to merge is to make it easier during development. If a test fails we won't have to open an additional PR to fix anything we might miss.

@ctran88 ctran88 force-pushed the PSG-4994-remove-e2e-tests branch from e3fd888 to 2cf78c8 Compare January 2, 2025 21:48
@ctran88 ctran88 force-pushed the PSG-4994-remove-e2e-tests branch from 2cf78c8 to f676461 Compare January 2, 2025 21:52
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 2, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@ctran88 ctran88 merged commit c6b5746 into main Jan 2, 2025
6 checks passed
@ctran88 ctran88 deleted the PSG-4994-remove-e2e-tests branch January 2, 2025 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vanessa-passage vanessa-passage vanessa-passage approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ctran88 @vanessa-passage